fix(sms): accept a gateway reply with debug text before its JSON

The relay gateway now prints timing lines before its result, e.g.
"1. Function Start at: ...<br>...572381951{"data":"sent"}". The message
was delivered, but the whole body is not JSON, so it was logged as a failed
SMS. When the body does not parse, the trailing JSON object is read instead.
A body with no JSON at all (the gateway's bare PHP errors) still fails.

Tests: sms.service.spec (relayRejection). 33 SMS tests pass.

پیامکِ ارسال‌شده دیگر به اشتباه در گزارش سرور «ناموفق» ثبت نمی‌شود.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
s.esmaeili
2026-10-10 16:39:41 +03:30
co-authored by Cursor
parent 797d030e67
commit 840311a2a0
3 changed files with 28 additions and 3 deletions
+8 -1
View File
@@ -87622,7 +87622,14 @@ var require_relay_driver = __commonJS({
try {
data = JSON.parse(text);
} catch {
return text.slice(0, 200);
const trailing = /\{[^{}]*\}$/.exec(text);
try {
if (!trailing)
throw new Error("no json");
data = JSON.parse(trailing[0]);
} catch {
return text.slice(0, 200);
}
}
if (!data || typeof data !== "object" || Array.isArray(data))
return null;
@@ -90,9 +90,13 @@ export function relayConfig() {
* body plainly says otherwise. Returns the reason, or null when the reply
* reads as accepted.
*
* A non-empty body that is not JSON counts as a failure: the gateway is a JSON
* A non-empty body with no JSON counts as a failure: the gateway is a JSON
* API, and its own PHP errors arrive as bare text with HTTP 200 — seen live on
* 2026-10-05 as "cURL library is not loaded", with nothing delivered.
*
* The gateway may print debug text before its JSON (seen live on 2026-10-10:
* "1. Function Start at: …<br>…572381951{"data":"sent"}"), so the trailing
* JSON object is read when the whole body does not parse.
*/
export function relayRejection(body: string): string | null {
const text = body.trim();
@@ -102,7 +106,13 @@ export function relayRejection(body: string): string | null {
try {
data = JSON.parse(text);
} catch {
return text.slice(0, 200);
const trailing = /\{[^{}]*\}$/.exec(text);
try {
if (!trailing) throw new Error('no json');
data = JSON.parse(trailing[0]);
} catch {
return text.slice(0, 200);
}
}
if (!data || typeof data !== 'object' || Array.isArray(data)) return null;
@@ -190,6 +190,14 @@ describe('relayRejection', () => {
it('rejects a bare-text body — the gateway reports its own PHP errors that way', () => {
expect(relayRejection('cURL library is not loaded')).toBe('cURL library is not loaded');
});
it('reads the trailing JSON when the gateway prints debug text before it', () => {
const debug =
'1. Function Start at: 13:07:25:586<br>2. Request Sending (Standard) at: 13:07:25:586<br>' +
'Total Duration: 0.2961 seconds<br>572381951';
expect(relayRejection(debug + '{"data":"sent"}')).toBeNull();
expect(relayRejection(debug + '{"status":false,"message":"bad phone"}')).toBe('bad phone');
});
});
describe('SmsService.send', () => {