parity(docs): D16 — stop PRICE-01 as storefront, reorder Phase 1, verify SEC-02
Owner ruling: computing and displaying price / price_with_discount is retail storefront work, so it falls under D13 and is marked out of scope. The B2B app works in making charge only. variant-price.ts and its 11 hand-checked tests are kept and still run, just unused. Nothing needed reverting: computeVariantPrice was never called from outside its own file and spec, verified by grep over apps/api/src and apps/admin-panel/src, so no price had been wired into any screen. PRICE-01 is re-marked in ISSUES.md rather than deleted so the evidence survives if the storefront is ever taken up. Making-charge work stays fully in scope: percentage_pay, makingChargeOffsetPercent, and wage display on variants and order lines. New Phase 1 order: Persons -> products/categories/variants/order detail -> financial documents -> users and permissions -> admin SMS -> promotions, notifications, cities, branches, workshops -> reports -> gate. Per section: implement the gaps, then field-by-field test that section, and show a gap summary before fixing. SEC-02 re-verified live rather than quoted: 9/9 assertions, plus 32/32 in auth-smoke.sh. POST /orders is 401 without a token; a body customerId of "customer-2" sent with a customer-dev-test token still lands the order on customer-dev-test and is warn-logged; a foreign order id returns 404 rather than 403 so ids stay unenumerable; the admin read rejects a customer token. Client-supplied wagePercent/discountPercent/flatRialCharge remain as MON-08, already scheduled as Phase 2 item #1. Also records why the dev OTP log briefly looked broken: a stale API process still held port 3077, so the new instance died with EADDRINUSE and the tailed log belonged to the old process. Not a regression. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
64e76a8616
commit
e3af31948e
@@ -398,3 +398,51 @@ reliably, 0 single-token, 0 empty, **1 needs review** — `customer-dev-test`
|
||||
first name «محمد علی» survives intact, which is the defect the owner
|
||||
originally reported.
|
||||
- Typecheck: api ✅ · admin-panel ✅.
|
||||
|
||||
---
|
||||
|
||||
## 2026-09-22 (later still) — D16 priority change, SEC-02 re-verified
|
||||
|
||||
### PRICE-01 stopped (D16)
|
||||
|
||||
Price display is retail-storefront work, so it falls under D13 and is now ⏸️.
|
||||
|
||||
- `apps/api/src/modules/pricing/variant-price.ts` and its 11 tests are **kept**
|
||||
and still run; they are simply not used.
|
||||
- **Nothing needed reverting.** `computeVariantPrice` was never called from
|
||||
anywhere outside its own file and spec — verified by grep over `apps/api/src`
|
||||
and `apps/admin-panel/src`. No code had been wired to display a price.
|
||||
- Making-charge work (`percentage_pay`, `makingChargeOffsetPercent`, wage display
|
||||
on variants and order lines) **stays in scope**.
|
||||
- `ISSUES.md` PRICE-01 re-marked ⏸️ rather than deleted, so the evidence survives.
|
||||
|
||||
### SEC-02 re-verified live
|
||||
|
||||
Re-tested end to end rather than quoting the earlier run:
|
||||
|
||||
| Check | Result |
|
||||
|---|---|
|
||||
| `POST /orders` with no token | 401 |
|
||||
| Body `customerId: "customer-2"` + `customer-dev-test` token | landed on **customer-dev-test**; warn-logged |
|
||||
| `GET /orders/:id` own | 200 |
|
||||
| `GET /orders/:id` another customer's | **404** (not 403) |
|
||||
| `GET /orders/:id` unknown | 404, identical |
|
||||
| `GET /orders/admin/:id` with a customer token | 401 |
|
||||
|
||||
**9/9 passed**, plus **32/32** in `auth-smoke.sh`.
|
||||
|
||||
### Data deletions (standing rule 2)
|
||||
|
||||
| What | How many | Why |
|
||||
|---|---|---|
|
||||
| 1 `Order` created by the SEC-02 test, with its `OrderItem`, `OrderStatusEvent` and `LedgerEntry` rows | 1 order + its children | Test fixture, removed by the test itself. |
|
||||
|
||||
### A testing note worth keeping
|
||||
|
||||
The dev OTP line briefly appeared to be missing after the SMS change. It was not
|
||||
a regression: a **stale API process from an earlier test still held port 3077**,
|
||||
so the new instance died with `EADDRINUSE` and the log being tailed belonged to
|
||||
the old process. Kill the listener (`netstat -ano | grep :3077`) before
|
||||
concluding anything from a log. `smsConfigured()` returns false with no
|
||||
credentials, so the dev log fires exactly as intended — confirmed once the port
|
||||
was free.
|
||||
|
||||
Reference in New Issue
Block a user