s.esmaeiliandClaude Opus 5
4efe543d62
Stage 1 narrowed GET /customers but did not close the leak: the response still
carried every customer id, and /customers/:id, /:id/orders and
/:id/ledger-entries were still public, so the full customer book was still two
requests away. The user caught this. Stage 2 deletes the id-bearing surface.
Customer JWT, separate from the admin one (T1):
- new src/modules/customer-auth/ with its own passport strategy,
CustomerJwtGuard, @CustomerAuth() and @CurrentCustomer()
- signed with JWT_CUSTOMER_SECRET, and every token carries typ:'customer'
which the strategy verifies; both checks are present deliberately
- customer state re-read per request, so deactivating takes effect at once
- mirrors the reference's own split: auth:api vs auth('api-customer')
Real OTP (D6), porting ApiMobileController::userAuth/userVerfiy (:39-64):
- new CustomerOtp table, additive migration, nothing existing touched
- parity behaviour: rand(1000,9999), active-customer filter, faTOen digit
normalisation on both number and code, rejection on mismatch
- approved improvements over the reference: bcrypt-hashed code, 2-minute
expiry, 5 attempts then lockout, single use, send throttle (60s per
number, 5/number and 20/IP per 10 min), and no number enumeration
Routes removed, replaced by token-derived equivalents:
GET customers, customers/:id, /:id/orders, /:id/ledger-entries
-> GET customer/me, customer/me/orders, customer/me/ledger-entries
No route accepts a customer id any more, so the IDOR is closed structurally
rather than by a check. The admin panel was unaffected (admin/customers-omde/*).
Both apps migrated in the same commit per the v1/v2 parity rule: token-based
session store, Bearer header, 401 -> clear session and route to login, real
two-step OTP login. Each app keeps its own markup and styling; only logic moved.
Tests: auth-smoke.sh extended with the stage-2 assertions, 46 passed 0 failed
against a live server. jest installed dev-only (user-approved) so pnpm test
works for the first time: 7 passed covering faToEn, which moved to its own
digits.ts to be testable without booting Nest. Typecheck clean on api,
user-app and user-app-v2; both apps build.
[ref: henza_server ApiMobileController.php:39-78]
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
42 lines
1.5 KiB
TypeScript
42 lines
1.5 KiB
TypeScript
import { createApp } from 'vue';
|
|
import { createPinia } from 'pinia';
|
|
import VueLazyLoad from 'vue3-lazyload';
|
|
import App from './App.vue';
|
|
import { router } from './router';
|
|
import { setUnauthorizedHandler } from './api/client';
|
|
import { useSessionStore } from './stores/session';
|
|
import Container from './components/ui/Container.vue';
|
|
import Vector from './assets/img/Vector.svg';
|
|
|
|
// Global styles, ported from legacy henza_pwa/src/main.ts — same import order
|
|
// (ant-design-vue's own theme first, then our Less overrides on top). Legacy
|
|
// imported 'vant/lib/index.css' twice (a dead duplicate) — imported once here.
|
|
import './assets/styles/tailwind.css';
|
|
import 'ant-design-vue/dist/antd.less';
|
|
import './assets/styles/style.less';
|
|
import 'vant/lib/index.css';
|
|
|
|
const app = createApp(App);
|
|
|
|
app.use(createPinia());
|
|
app.use(router);
|
|
|
|
// A 401 from the API means the customer token is gone or expired. Clear the
|
|
// session and send the user to login, so no stale personal data stays on
|
|
// screen behind a dead token. Registered after Pinia so the store exists.
|
|
setUnauthorizedHandler(() => {
|
|
useSessionStore().logout();
|
|
if (router.currentRoute.value.name !== 'login') {
|
|
void router.push({ name: 'login' });
|
|
}
|
|
});
|
|
// Ported from legacy main.ts:32-46 — Vector.svg is both the while-loading and
|
|
// the on-error placeholder, so a missing/failed image paints the brand mark
|
|
// instead of collapsing the layout.
|
|
app.use(VueLazyLoad, {
|
|
loading: Vector,
|
|
error: Vector,
|
|
});
|
|
app.component('container', Container);
|
|
app.mount('#app');
|